8ad9cf8537
Patch Set 8:
(1 comment)
Patch-set: 8
Attention: {"person_ident":"Gerrit User 31245 \u003c31245@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_31245\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 32553 \u003c32553@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_31245\u003e replied on the change"}
109 lines
3.3 KiB
Plaintext
109 lines
3.3 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "d4ec0c50_32be1d30",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 31245
|
|
},
|
|
"writtenOn": "2024-02-01T10:01:34Z",
|
|
"side": 1,
|
|
"message": "Looks good to merge.",
|
|
"revId": "87dcb1b1d0ffb47f66ddbc5721043fe774e34e99",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "a3abb7c2_25412762",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 32553
|
|
},
|
|
"writtenOn": "2024-02-01T13:10:21Z",
|
|
"side": 1,
|
|
"message": "I just notified Matus what he thinks about your implementation.\nI hope we can find an implementation that suits us all. @matus.jenca@dnation.cloud can you comment if this would work for us as well?\n\nThank you all.",
|
|
"revId": "87dcb1b1d0ffb47f66ddbc5721043fe774e34e99",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "a6f4fa30_05704b44",
|
|
"filename": "oslo_cache/core.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 246,
|
|
"author": {
|
|
"id": 31245
|
|
},
|
|
"writtenOn": "2024-02-01T10:01:34Z",
|
|
"side": 1,
|
|
"message": "Wondering why you change name of variable here?",
|
|
"revId": "87dcb1b1d0ffb47f66ddbc5721043fe774e34e99",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "c4701143_e979206a",
|
|
"filename": "oslo_cache/core.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 246,
|
|
"author": {
|
|
"id": 32553
|
|
},
|
|
"writtenOn": "2024-02-01T10:43:33Z",
|
|
"side": 1,
|
|
"message": "I\u0027m wondering the same, I actually liked the old name more, as it\u0027s easier to understand, because there is no need to know the meaning of the abbreviation.",
|
|
"parentUuid": "a6f4fa30_05704b44",
|
|
"revId": "87dcb1b1d0ffb47f66ddbc5721043fe774e34e99",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "473c1ca5_2c2c9b9c",
|
|
"filename": "oslo_cache/core.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 246,
|
|
"author": {
|
|
"id": 9816
|
|
},
|
|
"writtenOn": "2024-02-01T11:07:15Z",
|
|
"side": 1,
|
|
"message": "I shortened the name to fit L260 in 79 chars limit. I can revert this change but L260 may need to be spread to two lines.",
|
|
"parentUuid": "c4701143_e979206a",
|
|
"revId": "87dcb1b1d0ffb47f66ddbc5721043fe774e34e99",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "4eb6d1ed_967e56a8",
|
|
"filename": "oslo_cache/core.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 246,
|
|
"author": {
|
|
"id": 31245
|
|
},
|
|
"writtenOn": "2024-02-01T14:55:00Z",
|
|
"side": 1,
|
|
"message": "As you prefer but to be honest I think the old name is more clear, so I prefer the old one.",
|
|
"parentUuid": "473c1ca5_2c2c9b9c",
|
|
"revId": "87dcb1b1d0ffb47f66ddbc5721043fe774e34e99",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |