Update patch set 4

Patch Set 4: Code-Review-1 (1 comment) See also comments in test_processutils in previous patchset. Patch-set: 4 Label: Code-Review=-1
2014-08-20 13:43:42 +00:00 · 2014-08-20 13:43:42 +00:00 · 9fe9b90d08
parent d60294e019
commit 9fe9b90d08
1 changed files with 27 additions and 0 deletions
--- a/27
+++ b/27
@ -0,0 +1,27 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "1abeadc6_e67070de",
+        "filename": "oslo/concurrency/processutils.py",
+        "patchSetId": 4
+      },
+      "lineNbr": 123,
+      "author": {
+        "id": 708
+      },
+      "writtenOn": "2014-08-20T13:43:42Z",
+      "side": 1,
+      "message": "Please add quotes around \u0027final\u0027 and \u0027all\u0027. Also we should mention that this is about errors in different attempts, like this:\n\n\u0027final\u0027 implies log only on error on the last attempt, \u0027all\u0027 implies log on every error on every attempt",
+      "range": {
+        "startLine": 122,
+        "startChar": 36,
+        "endLine": 123,
+        "endChar": 58
+      },
+      "revId": "7be29d6429824da0bafb589209c752486c7083e5",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}