openstack/oslo.concurrency
Code Issues Proposed changes

provide sane cmd exit reporting

Browse Source 
Previously the debug messages around command exit were a naked return
code with no reference to what was run. When dealing with very long
running commands (especially those that fail) this means that figuring
out what command was run is possibly very difficult.

Change-Id: I6c44e1106f77fab517fcb0b6d6dd8ed56c853496
This commit is contained in:
Sean Dague 2014-09-24 11:27:12 -04:00
parent 34f5b81987
commit efc4354522
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
oslo/concurrency/processutils.py
View File

@ -23,6 +23,7 @@ import os
import random
import shlex
import signal
import time
from eventlet.green import subprocess
from eventlet import greenthread
@ -176,6 +177,7 @@ def execute(*cmd, **kwargs):
while attempts > 0:
attempts -= 1
try:
start_time = time.time()
LOG.log(loglevel, _('Running cmd (subprocess): %s'), sanitized_cmd)
_PIPE = subprocess.PIPE # pylint: disable=E1101
@ -199,7 +201,9 @@ def execute(*cmd, **kwargs):
obj.stdin.close() # pylint: disable=E1101
_returncode = obj.returncode # pylint: disable=E1101
LOG.log(loglevel, 'Result was %s' % _returncode)
end_time = time.time() - start_time
LOG.log(loglevel, 'CMD "%s" returned: %s in %ss' %
(sanitized_cmd, _returncode, end_time))
if not ignore_exit_code and _returncode not in check_exit_code:
(stdout, stderr) = result
sanitized_stdout = strutils.mask_password(stdout)