Update patch set 2
Patch Set 2: Code-Review-1 (1 comment) The fix looks fine but I left some style comments on the test inline. Patch-set: 2 Label: Code-Review=-1
This commit is contained in:
parent
0305b0f646
commit
fed6946cf9
|
@ -0,0 +1,21 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1abeadc6_4c543f54",
|
||||
"filename": "tests/unit/test_processutils.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 234,
|
||||
"author": {
|
||||
"id": 2472
|
||||
},
|
||||
"writtenOn": "2014-08-18T16:24:17Z",
|
||||
"side": 1,
|
||||
"message": "I think this bash script would be easier to read if it was saved to a module-level multi-line string with backslashes escaping anything the multi-line string syntax can\u0027t handle directly. As it is, we have to convert from Python to a string in our heads and then parse the result with bash syntax in our head again to understand what is being tested.",
|
||||
"revId": "4efa55ed43a97d7bc71a5e09e1254cb23aa04ece",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue