From 5439d6bf290ec43f2ecddb1696eaa1a4ba114e07 Mon Sep 17 00:00:00 2001
From: Zhongyue Luo <zhongyue.nah@intel.com>
Date: Thu, 21 Mar 2013 16:35:26 +0800
Subject: [PATCH] Adds pylint section in tox.ini in oslo.config to check for
 unused imports

Fixes bug #1157597

Change-Id: I58057cdde6064dacf6689560ec6439fd6dc7cf4f
---
 tools/lint.py | 34 ++++++++++++++++++++++++++++++++++
 tox.ini       |  7 ++++++-
 2 files changed, 40 insertions(+), 1 deletion(-)
 create mode 100644 tools/lint.py

diff --git a/tools/lint.py b/tools/lint.py
new file mode 100644
index 00000000..69b88ca3
--- /dev/null
+++ b/tools/lint.py
@@ -0,0 +1,34 @@
+# vim: tabstop=4 shiftwidth=4 softtabstop=4
+
+# Copyright (c) 2013 Intel Corporation.
+# All Rights Reserved.
+#
+#    Licensed under the Apache License, Version 2.0 (the "License"); you may
+#    not use this file except in compliance with the License. You may obtain
+#    a copy of the License at
+#
+#         http://www.apache.org/licenses/LICENSE-2.0
+#
+#    Unless required by applicable law or agreed to in writing, software
+#    distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+#    License for the specific language governing permissions and limitations
+#    under the License.
+#
+# @author: Zhongyue Luo, Intel Corporation.
+#
+
+import sys
+
+from pylint import lint
+
+
+ENABLED_PYLINT_MSGS = ['W0611']
+
+
+def main(dirpath):
+    enable_opt = '--enable=%s' % ','.join(ENABLED_PYLINT_MSGS)
+    lint.Run(['--reports=n', '--disable=all', enable_opt, dirpath])
+
+if __name__ == '__main__':
+    main(sys.argv[1])
diff --git a/tox.ini b/tox.ini
index b66a2335..751bd8f9 100644
--- a/tox.ini
+++ b/tox.ini
@@ -1,5 +1,5 @@
 [tox]
-envlist = py26,py27,pep8
+envlist = py26,py27,pep8,pylint
 
 [testenv]
 setenv = VIRTUAL_ENV={envdir}
@@ -11,6 +11,11 @@ commands = nosetests --with-doctest --exclude-dir=tests/testmods {posargs}
 deps = pep8==1.3.3
 commands = pep8 --repeat --show-source --exclude=.tox,dist,doc,*.egg --ignore=E125 .
 
+[testenv:pylint]
+deps = pylint>=0.26.0
+commands = python ./tools/lint.py ./oslo
+           python ./tools/lint.py ./tests
+
 [testenv:cover]
 setenv = NOSE_WITH_COVERAGE=1