From 561db7ac328417cb9091a21798b8b9e9def35e6a Mon Sep 17 00:00:00 2001 From: "huang.xiangdong" Date: Fri, 1 Nov 2019 11:18:21 +0800 Subject: [PATCH] fix: fix float opt min and max value format errror "%d" will truncate float and generates wrong format message, use "format" to handle floats correctly. Closes-Bug: 1850879 Change-Id: If0dd3933695ac84f0e9cacefd28a9d7a60dd88d7 --- oslo_config/generator.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/oslo_config/generator.py b/oslo_config/generator.py index 475b2442..ba75c4ce 100644 --- a/oslo_config/generator.py +++ b/oslo_config/generator.py @@ -255,10 +255,10 @@ class _OptFormatter(object): lines = self._format_help(help_text) if getattr(opt.type, 'min', None) is not None: - lines.append('# Minimum value: %d\n' % opt.type.min) + lines.append('# Minimum value: {}\n'.format(opt.type.min)) if getattr(opt.type, 'max', None) is not None: - lines.append('# Maximum value: %d\n' % opt.type.max) + lines.append('# Maximum value: {}\n'.format(opt.type.max)) if getattr(opt.type, 'choices', None): lines.append('# Possible values:\n')