openstack/oslo.config
Code Issues Proposed changes

Fixes "is not", "not in" syntax usage.

Browse Source 
Replaced "not ... is" to "is not"
Replaced "not ... in" to "not in"
Removed a redundant parenthesis

Change-Id: I9564ab1207ccdcb32d7c2bb9e8f29658b2232ff9
This commit is contained in:
Zhongyue Luo
2013-01-28 14:35:49 +08:00
committed by Mark McLoughlin
parent 9805067bcf
commit a118969fb7
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
oslo/config/cfg.py
View File

@@ -863,7 +863,7 @@ class SubCommandOpt(Opt):
description=self.description, description=self.description,
help=self.help) help=self.help)
if not self.handler is None: if self.handler is not None:
self.handler(subparsers) self.handler(subparsers)
@@ -1547,8 +1547,8 @@ class ConfigOpts(collections.Mapping):
group = group_or_name if isinstance(group_or_name, OptGroup) else None group = group_or_name if isinstance(group_or_name, OptGroup) else None
group_name = group.name if group else group_or_name group_name = group.name if group else group_or_name
if not group_name in self._groups: if group_name not in self._groups:
if not group is None or not autocreate: if group is not None or not autocreate:
raise NoSuchGroupError(group_name) raise NoSuchGroupError(group_name)
self.register_group(OptGroup(name=group_name)) self.register_group(OptGroup(name=group_name))
@@ -1568,7 +1568,7 @@ class ConfigOpts(collections.Mapping):
group = self._get_group(group) group = self._get_group(group)
opts = group._opts opts = group._opts
if not opt_name in opts: if opt_name not in opts:
raise NoSuchOptError(opt_name, group) raise NoSuchOptError(opt_name, group)
return opts[opt_name] return opts[opt_name]
@@ -1606,7 +1606,7 @@ class ConfigOpts(collections.Mapping):
opt = info['opt'] opt = info['opt']
if opt.required: if opt.required:
if ('default' in info or 'override' in info): if 'default' in info or 'override' in info:
continue continue
if self._get(opt.dest, group) is None: if self._get(opt.dest, group) is None: