openstack
/
oslo.config
Code Issues Proposed changes

Merge "Improve removing quotes logic"

This commit is contained in:
Zuul 2019-08-14 20:49:52 +00:00 committed by Gerrit Code Review
parent 01a632e243 8ab5fa2d45
commit c4d8fa7b88
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
oslo_config/tests/test_types.py
View File

@ -93,6 +93,11 @@ class StringTypeTests(TypeTestHelper, unittest.TestCase):
self.type_instance = types.String(quotes=True)
self.assertConvertedValue('foo bar"', 'foo bar"')
def test_single_quote_is_invalid(self):
self.type_instance = types.String(quotes=True)
self.assertInvalid('"')
self.assertInvalid("'")
def test_repr(self):
t = types.String()
self.assertEqual('String', repr(t))

2
oslo_config/types.py
View File

@ -144,7 +144,7 @@ class String(ConfigType):
value = str(value)
if self.quotes and value:
if value[0] in "\"'":
if value[-1] != value[0]:
if len(value) == 1 or value[-1] != value[0]:
raise ValueError('Non-closed quote: %s' % value)
value = value[1:-1]