openstack
/
oslo.db
Code Issues Proposed changes

migration.db_sync requires an engine now 

One of the migration test cases was still not passing an engine to
db_sync.  This doesn't show up in the gate because it is a negative
test that was failing with the correct exception for a different
reason.  I happened to find the problem because I had a file named
foo in my oslo-incubator directory from some previous testing and foo
was being passed in as the repository path, so that call wasn't
failing like it would on a clean system such as the gate.

Change-Id: Ia10cfbd4b99d821d9a725e6eb256fdd8ab001405
This commit is contained in:
Ben Nemec 2014-02-20 16:49:23 +00:00
parent e0ba0851aa
commit 2548ff77d0
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/unit/db/sqlalchemy/test_migration_common.py
View File

@ -116,8 +116,8 @@ class TestMigrationCommon(test_base.DbTestCase):
self.engine, self.path, self.init_version)
def test_db_sync_wrong_version(self):
self.assertRaises(
db_exception.DbMigrationError, migration.db_sync, self.path, 'foo')
self.assertRaises(db_exception.DbMigrationError,
migration.db_sync, self.engine, self.path, 'foo')
def test_db_sync_upgrade(self):
init_ver = 55