openstack/oslo.db
Code Issues Proposed changes

Extract logging setup into a separate function

Browse Source 
Change-Id: I9f1761a5332ad3c4a8f0b76c6f46fc687fd61aa5
This commit is contained in:
Roman Vasilets 2014-08-08 15:44:42 +03:00
parent 76c0676687
commit 41dada16cd
1 changed files with 20 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
oslo/db/sqlalchemy/session.py
View File

@ -331,6 +331,25 @@ def _begin_ping_listener(connection):
connection.scalar(select([1]))
def _setup_logging(connection_debug=0):
"""setup_logging function maps SQL debug level to Python log level.
Connection_debug is a verbosity of SQL debugging information.
0=None(default value),
1=Processed only messages with WARNING level or higher
50=Processed only messages with INFO level or higher
100=Processed only messages with DEBUG level
"""
if connection_debug >= 0:
logger = logging.getLogger('sqlalchemy.engine')
if connection_debug >= 100:
logger.setLevel(logging.DEBUG)
elif connection_debug >= 50:
logger.setLevel(logging.INFO)
else:
logger.setLevel(logging.WARNING)
def create_engine(sql_connection, sqlite_fk=False, mysql_sql_mode=None,
idle_timeout=3600,
connection_debug=0, max_pool_size=None, max_overflow=None,
@ -346,15 +365,7 @@ def create_engine(sql_connection, sqlite_fk=False, mysql_sql_mode=None,
'convert_unicode': True,
}
if connection_debug >= 0:
# Map SQL debug level to Python log level
logger = logging.getLogger('sqlalchemy.engine')
if connection_debug >= 100:
logger.setLevel(logging.DEBUG)
elif connection_debug >= 50:
logger.setLevel(logging.INFO)
else:
logger.setLevel(logging.WARNING)
_setup_logging(connection_debug)
_init_connection_args(
url, engine_args,