openstack/oslo.db
Code Issues Proposed changes

Remove provisioned_engine in class BackendImpl

Browse Source 
This method is useless in class BackendImpl.
So it is deprecated for removal.

Change-Id: I3c73acc6b02da731a73880146661b63e75657982
Closes-Bug:#1714778
This commit is contained in:
zhangyangyang 2017-09-03 21:29:57 +08:00
parent 69910499a7
commit 528abcb545
1 changed files with 0 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
oslo_db/sqlalchemy/provision.py
View File

@ -17,7 +17,6 @@
"""Provision test environment for specific DB backends""" """Provision test environment for specific DB backends"""
import abc import abc
import debtcollector
import logging import logging
import os import os
import random import random
@ -33,7 +32,6 @@ import testresources
from oslo_db import exception from oslo_db import exception
from oslo_db.sqlalchemy import enginefacade from oslo_db.sqlalchemy import enginefacade
from oslo_db.sqlalchemy import session
from oslo_db.sqlalchemy import utils from oslo_db.sqlalchemy import utils
LOG = logging.getLogger(__name__) LOG = logging.getLogger(__name__)
@ -503,39 +501,10 @@ class BackendImpl(object):
url.database = ident url.database = ident
return url return url
@debtcollector.removals.remove()
def provisioned_engine(self, base_url, ident):
"""Return a provisioned engine.
Given the URL of a particular database backend and the string
name of a particular 'database' within that backend, return
an Engine instance whose connections will refer directly to the
named database.
For hostname-based URLs, this typically involves switching just the
'database' portion of the URL with the given name and creating
an engine.
For URLs that instead deal with DSNs, the rules may be more custom;
for example, the engine may need to connect to the root URL and
then emit a command to switch to the named database.
"""
url = self.provisioned_database_url(base_url, ident)
return session.create_engine(
url,
logging_name="%s@%s" % (self.drivername, ident),
**self.default_engine_kwargs
)
@BackendImpl.impl.dispatch_for("mysql") @BackendImpl.impl.dispatch_for("mysql")
class MySQLBackendImpl(BackendImpl): class MySQLBackendImpl(BackendImpl):
# only used for deprecated provisioned_engine() function.
default_engine_kwargs = {'mysql_sql_mode': 'TRADITIONAL'}
def create_opportunistic_driver_url(self): def create_opportunistic_driver_url(self):
return "mysql+pymysql://openstack_citest:openstack_citest@localhost/" return "mysql+pymysql://openstack_citest:openstack_citest@localhost/"