openstack
/
oslo.db
Code Issues Proposed changes

Remove convert_unicode flag 

This flag is to be deprecated in SQLAlchemy version 1.3,
as it is a leftover from the pre-Python 3 legacy days when
DBAPIs under Python 2 would crash if you passed them a
u'' object.   While still available in 1.3, it will emit a
deprecation warning, so it's time to stop using this flag and to
locate any downstream Openstack projects that might be relying
on its behavior in a Python 2 context; the flag has no real effect
on Python 3.

Change-Id: I01984b4ff7e03dcf91ef8dcb05da67dda8270ae3
References: https://github.com/sqlalchemy/sqlalchemy/issues/4393
This commit is contained in:
Mike Bayer 2018-12-21 12:50:25 -05:00
parent f1be3e74a6
commit a6d2cc57d4
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
oslo_db/sqlalchemy/engines.py
View File

@ -159,7 +159,6 @@ def create_engine(sql_connection, sqlite_fk=False, mysql_sql_mode=None,
engine_args = { engine_args = {
"pool_recycle": connection_recycle_time, "pool_recycle": connection_recycle_time,
'convert_unicode': True,
'connect_args': {}, 'connect_args': {},
'logging_name': logging_name 'logging_name': logging_name
} }