openstack/oslo.db
Code Issues Proposed changes

Replaces uuid.uuid4 with uuidutils.generate_uuid()

Browse Source 
Openstack common has a wrapper for generating uuids. We should
use that function when generating uuids for consistency.

Change-Id: I927609f06e5921e189487160ef46be830e422add
Closes-Bug: #1082248
This commit is contained in:
zhangguoqing 2016-12-07 02:41:10 +00:00
parent e8e2421f8b
commit d77439bd93
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
oslo_db/tests/sqlalchemy/test_utils.py
View File

@ -13,10 +13,9 @@
# License for the specific language governing permissions and limitations # License for the specific language governing permissions and limitations
# under the License. # under the License.
import uuid
import fixtures import fixtures
import mock import mock
from oslo_utils import uuidutils
from oslotest import base as test_base from oslotest import base as test_base
from oslotest import moxstubout from oslotest import moxstubout
import six import six
@ -726,7 +725,7 @@ class TestMigrationUtils(db_test_base.DbTestCase):
select_table_name = "__test_select_from_table__" select_table_name = "__test_select_from_table__"
uuidstrs = [] uuidstrs = []
for unused in range(10): for unused in range(10):
uuidstrs.append(uuid.uuid4().hex) uuidstrs.append(uuidutils.generate_uuid(dashed=False))
insert_table = Table( insert_table = Table(
insert_table_name, self.meta, insert_table_name, self.meta,
Column('id', Integer, primary_key=True, Column('id', Integer, primary_key=True,
@ -766,7 +765,7 @@ class TestMigrationUtils(db_test_base.DbTestCase):
select_table_name = "__test_select_from_table__" select_table_name = "__test_select_from_table__"
uuidstrs = [] uuidstrs = []
for unused in range(10): for unused in range(10):
uuidstrs.append(uuid.uuid4().hex) uuidstrs.append(uuidutils.generate_uuid(dashed=False))
insert_table = Table( insert_table = Table(
insert_table_name, self.meta, insert_table_name, self.meta,
Column('id', Integer, primary_key=True, Column('id', Integer, primary_key=True,
@ -806,7 +805,7 @@ class TestMigrationUtils(db_test_base.DbTestCase):
select_table_name = "__test_select_from_table__" select_table_name = "__test_select_from_table__"
uuidstrs = [] uuidstrs = []
for unused in range(10): for unused in range(10):
uuidstrs.append(uuid.uuid4().hex) uuidstrs.append(uuidutils.generate_uuid(dashed=False))
insert_table = Table( insert_table = Table(
insert_table_name, self.meta, insert_table_name, self.meta,
Column('id', Integer, primary_key=True, Column('id', Integer, primary_key=True,