Update patch set 1
Patch Set 1: Code-Review-1 (1 comment) Patch-set: 1 Reviewer: Gerrit User 15334 <15334@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1, 3843542239c6f5df95e769c3d43f85dbf8df8908
This commit is contained in:
parent
cb3743b433
commit
acab3a34da
|
@ -0,0 +1,21 @@
|
||||||
|
{
|
||||||
|
"comments": [
|
||||||
|
{
|
||||||
|
"unresolved": false,
|
||||||
|
"key": {
|
||||||
|
"uuid": "01e90178_303faa53",
|
||||||
|
"filename": "/PATCHSET_LEVEL",
|
||||||
|
"patchSetId": 1
|
||||||
|
},
|
||||||
|
"lineNbr": 0,
|
||||||
|
"author": {
|
||||||
|
"id": 15334
|
||||||
|
},
|
||||||
|
"writtenOn": "2023-02-17T11:48:05Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "These test failures are real. We\u0027ve got mocks of getdefaultlocale which need to be updated. The replacement suggested also feels slightly reductive. Looking at the logic for \u0027getdefaultlocale\u0027 [1], I see use trying multiple envvars. Shouldn\u0027t we be doing the same thing here?\n\n[1] https://github.com/python/cpython/blob/3.11/Lib/locale.py#L534",
|
||||||
|
"revId": "721dd76cb9a99973ae45cf5ff0e1e2f052281150",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
Loading…
Reference in New Issue