openstack
/
oslo.limit
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Workflow-1

(1 comment)

Patch-set: 1
Reviewer: Gerrit User 34325 <34325@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Workflow=-1
Attention: {"person_ident":"Gerrit User 28522 \u003c28522@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_34325\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 34325 \u003c34325@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_34325\u003e replied on the change"}
This commit is contained in:
Gerrit User 34325 2022-11-29 11:12:27 +00:00 committed by Gerrit Code Review
parent 4d030430b8
commit 22c460e72a
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
37f7acec4edf15163d87de3bf9d9dafca4bfb0c0
View File

@ -16,6 +16,24 @@
"message": "Globally these changes LGTM. You have a couple of pep8 error but nothing bad.\n\nPlease can you add a release note and some specific tests to ensure that this scenario is well covered over the years.\nMaybe somewhere here:\nhttps://opendev.org/openstack/oslo.limit/src/branch/master/oslo_limit/tests/test_limit.py\n\nThis file seems to host a couple of tests related to endpoint.",
"revId": "37f7acec4edf15163d87de3bf9d9dafca4bfb0c0",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "091306e0_03d3e73f",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 34325
},
"writtenOn": "2022-11-29T11:12:27Z",
"side": 1,
"message": "Sure, I will update with release note and test cases. Thanks!",
"parentUuid": "831e8ee6_25f1abf9",
"revId": "37f7acec4edf15163d87de3bf9d9dafca4bfb0c0",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}