39 lines
1.3 KiB
Plaintext
39 lines
1.3 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "831e8ee6_25f1abf9",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 28522
|
|
},
|
|
"writtenOn": "2022-11-29T09:31:05Z",
|
|
"side": 1,
|
|
"message": "Globally these changes LGTM. You have a couple of pep8 error but nothing bad.\n\nPlease can you add a release note and some specific tests to ensure that this scenario is well covered over the years.\nMaybe somewhere here:\nhttps://opendev.org/openstack/oslo.limit/src/branch/master/oslo_limit/tests/test_limit.py\n\nThis file seems to host a couple of tests related to endpoint.",
|
|
"revId": "37f7acec4edf15163d87de3bf9d9dafca4bfb0c0",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "091306e0_03d3e73f",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 34325
|
|
},
|
|
"writtenOn": "2022-11-29T11:12:27Z",
|
|
"side": 1,
|
|
"message": "Sure, I will update with release note and test cases. Thanks!",
|
|
"parentUuid": "831e8ee6_25f1abf9",
|
|
"revId": "37f7acec4edf15163d87de3bf9d9dafca4bfb0c0",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |