openstack
/
oslo.messaging
Code Issues Proposed changes

Add if condition for random.shuffle 

random.shuffle(hosts) only if the length of hosts > 1
then random.shuffle make sense.

Change-Id: I94fbf457a7ca73fe11aa97e52a58cde9298015a7
This commit is contained in:
XiaBing Yao 2015-08-12 13:27:26 -04:00
parent c4efc9ab87
commit 383abe0f5f
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
oslo_messaging/_drivers/impl_rabbit.py
View File

@ -407,7 +407,8 @@ class Connection(object):
LOG.warn(_LW('Selecting the kombu transport through the '
'transport url (%s) is a experimental feature '
'and this is not yet supported.') % url.transport)
random.shuffle(url.hosts)
if len(url.hosts) > 1:
random.shuffle(url.hosts)
for host in url.hosts:
transport = url.transport.replace('kombu+', '')
transport = transport.replace('rabbit', 'amqp')
@ -425,7 +426,8 @@ class Connection(object):
transport = url.transport.replace('kombu+', '')
self._url = "%s://%s" % (transport, virtual_host)
else:
random.shuffle(self.rabbit_hosts)
if len(self.rabbit_hosts) > 1:
random.shuffle(self.rabbit_hosts)
for adr in self.rabbit_hosts:
hostname, port = netutils.parse_host_port(
adr, default_port=self.rabbit_port)