openstack/oslo.messaging
Code Issues Proposed changes

Fix nits on kafka compression help text

Browse Source 
There is no need to explicitly list the choices in the help text.
The oslo.config sample generator will include the choices automatically[0]

Also tweaks the wording of text to make it clear that it is the allowed
values which vary based on kafka version.

Change-Id: I4116e8871436097dea650f56e7b187358367d92e
0: 2488c1e1ce/oslo_config/generator.py (L263)
This commit is contained in:
Ben Nemec 2019-08-06 19:00:24 +00:00
parent dfc8fe9a8f
commit 39196a4e90
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
oslo_messaging/_drivers/kafka_driver/kafka_options.py
View File

@ -51,9 +51,9 @@ KAFKA_OPTS = [
cfg.StrOpt('compression_codec', default='none',
choices=['none', 'gzip', 'snappy', 'lz4', 'zstd'],
help='The compression codec for all data generated by the '
'producer. Valid values are: gzip, snappy, lz4, zstd. If '
'not set, compression will not be used. Note that the '
'legal option of this depends on the kafka version'),
'producer. If not set, compression will not be used. '
'Note that the allowed values of this depend on the kafka '
'version'),
cfg.BoolOpt('enable_auto_commit',
default=False,