Update patch set 15
Patch Set 15: Code-Review-1 (1 comment) Typo in the release note that we should fix, although that could be done as a followup if you'd prefer. I'm also curious if we want the metrics module to be public. Consumers of oslo.messaging shouldn't be directly calling anything in there, right? Should we just make it private (oslo_messaging._metrics)? Patch-set: 15 Reviewer: Gerrit User 6928 <6928@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1
This commit is contained in:
parent
2b215e845b
commit
3c3021a075
|
@ -0,0 +1,27 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3fef8931_4b17c1bd",
|
||||
"filename": "releasenotes/notes/oslo-metrics-support-fe16343a637cc14b.yaml",
|
||||
"patchSetId": 15
|
||||
},
|
||||
"lineNbr": 7,
|
||||
"author": {
|
||||
"id": 6928
|
||||
},
|
||||
"writtenOn": "2021-06-07T15:45:58Z",
|
||||
"side": 1,
|
||||
"message": "*metrics",
|
||||
"range": {
|
||||
"startLine": 7,
|
||||
"startChar": 20,
|
||||
"endLine": 7,
|
||||
"endChar": 26
|
||||
},
|
||||
"revId": "23909b76f66301e094b20853ddb8d160c56fab5f",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue