openstack
/
oslo.messaging
Code Issues Proposed changes

Update patch set 2 

Patch Set 2: Code-Review-2

(1 comment)

There isn't anywhere near enough information about the bug in question here. I also think the fix is wrong. Could you please open a bug and expand the commit message to help everyone understand what you think is wrong and why the fix you've suggested will resolve the issue.

Patch-set: 2
Reviewer: Gerrit User 15334 <15334@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-2
This commit is contained in:
Gerrit User 15334 2021-10-04 16:59:05 +00:00 committed by Gerrit Code Review
parent 8a8998d076
commit 54b722808a
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
00d132c04c166f93d2853836e2f1c211ffd6b8a7 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"key": {
"uuid": "2f4cd422_74451a27",
"filename": "oslo_messaging/_drivers/impl_kafka.py",
"patchSetId": 2
},
"lineNbr": 326,
"author": {
"id": 15334
},
"writtenOn": "2021-10-04T16:59:05Z",
"side": 1,
"message": "A quick search suggests [1] that batch.size is not configurable and this is in fact the correct thing to do.\n\nIf you this is not the case, please illustrate why not. We\u0027d need a bug report and a much more detailed commit message, at a minimum\n\n[1] https://github.com/confluentinc/confluent-kafka-go/issues/348",
"revId": "00d132c04c166f93d2853836e2f1c211ffd6b8a7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}