openstack
/
oslo.messaging
Code Issues Proposed changes

Fix type of direct_mandatory_flag opt 

An IntOpt with a default of True is invalid. I'm a little surprised
this doesn't fail a defaults check somewhere, but it needs to be
fixed regardless.

Looking at where it is used, it appears the boolean type is correct.
This just changes the opt type to BoolOpt to match.

Conflicts:
  oslo_messaging/_drivers/impl_rabbit.py

NOTE(hberaud): Conflicts are due to a patch [1][2] not yet backported on
train and which added a new option on other branches.

[1] 196fa877a9
[2] https://review.opendev.org/c/openstack/oslo.messaging/+/747892

Change-Id: I01a38754a31c891f2b3b9c7f8135690693df5d13
Closes-Bug: 1909036
(cherry picked from commit b8f8b17030)
(cherry picked from commit a0329a3f86)
(cherry picked from commit 3bf9ba5504)
This commit is contained in:
Ben Nemec 2020-12-22 19:34:16 +00:00 committed by Hervé Beraud
parent a430ad873f
commit 56fc332608
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
oslo_messaging/_drivers/impl_rabbit.py
View File

@ -168,12 +168,12 @@ rabbit_opts = [
default=2,
help='How often times during the heartbeat_timeout_threshold '
'we check the heartbeat.'),
cfg.IntOpt('direct_mandatory_flag',
default=True,
help='Enable/Disable the RabbitMQ mandatory flag '
'for direct send. The direct send is used as reply,'
'so the MessageUndeliverable exception is raised'
' in case the client queue does not exist.'),
cfg.BoolOpt('direct_mandatory_flag',
default=True,
help='Enable/Disable the RabbitMQ mandatory flag '
'for direct send. The direct send is used as reply, '
'so the MessageUndeliverable exception is raised '
'in case the client queue does not exist.'),
]
LOG = logging.getLogger(__name__)