From f61f7c570f3b4de144b91587fd2c97aab091f05f Mon Sep 17 00:00:00 2001 From: Mehdi Abaakouk Date: Wed, 24 Sep 2014 17:41:17 +0200 Subject: [PATCH] Don't put the message payload into warning log When a caller msg doesn't exists anymore but a reply is ready for it. amqp driver drop the whole message into a logging.warn. That can be a bit huge in some case. This change just writes the message id to the WARN level and put the queues and the messages into the debug level. Change-Id: Ibcc6b066171cdea48f102ca1bd85f81c639fbbb5 --- oslo/messaging/_drivers/amqpdriver.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/oslo/messaging/_drivers/amqpdriver.py b/oslo/messaging/_drivers/amqpdriver.py index f0028251e..8f63ec8a7 100644 --- a/oslo/messaging/_drivers/amqpdriver.py +++ b/oslo/messaging/_drivers/amqpdriver.py @@ -26,6 +26,7 @@ from oslo import messaging from oslo.messaging._drivers import amqp as rpc_amqp from oslo.messaging._drivers import base from oslo.messaging._drivers import common as rpc_common +from oslo.messaging._i18n import _LI LOG = logging.getLogger(__name__) @@ -156,10 +157,9 @@ class ReplyWaiters(object): def put(self, msg_id, message_data): queue = self._queues.get(msg_id) if not queue: - LOG.warn('No calling threads waiting for msg_id : %(msg_id)s' - ', message : %(data)s', {'msg_id': msg_id, - 'data': message_data}) - LOG.warn('_queues: %s', self._queues) + LOG.info(_LI('No calling threads waiting for msg_id : %s'), msg_id) + LOG.debug(' queues: %(queues)s, message: %(message)', + {'queues': self._queues, 'message': message_data}) else: queue.put(message_data)