From 867525071cdb51dbe3e1d1f60280cda826de5495 Mon Sep 17 00:00:00 2001 From: Gerrit User 8770 <8770@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Mon, 7 Jun 2021 17:03:14 +0000 Subject: [PATCH] Update patch set 15 Patch Set 15: (1 comment) Other than a minor nit the patch looks fine, though I agree with Ben that (unless otherwise intended) the metric stuff should not be assumed public API. Patch-set: 15 Reviewer: Gerrit User 8770 <8770@4a232e18-c5a9-48ee-94c0-e04e7cca6543> --- 23909b76f66301e094b20853ddb8d160c56fab5f | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/23909b76f66301e094b20853ddb8d160c56fab5f b/23909b76f66301e094b20853ddb8d160c56fab5f index b856881f7..dcb425bf2 100644 --- a/23909b76f66301e094b20853ddb8d160c56fab5f +++ b/23909b76f66301e094b20853ddb8d160c56fab5f @@ -1,5 +1,22 @@ { "comments": [ + { + "key": { + "uuid": "e76168a4_ffc4028a", + "filename": "oslo_messaging/metrics/client.py", + "patchSetId": 15 + }, + "lineNbr": 53, + "author": { + "id": 8770 + }, + "writtenOn": "2021-06-07T17:03:14Z", + "side": 1, + "message": "multi-line help text like this needs a space at the end or beginning of the lines so the last and first words don\u0027t get squished together. Minor nit you can follow up with a separate patch if you\u0027d like.", + "revId": "23909b76f66301e094b20853ddb8d160c56fab5f", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": true + }, { "key": { "uuid": "3fef8931_4b17c1bd",