openstack/oslo.messaging
Code Issues Proposed changes

zmq: switch back to not using message envelopes

Browse Source 
In oslo-incubator, we default to not serializing messages using a
message envelope:

  def _cast(.., envelope=False, ...)

except using the v2 notifyer which explicitly passes envelope=True.

However, in oslo.messaging, we accidentally switched to using a
message envelope:

     def _send(self, ..., envelope=True):

This was not intentional and may be disruptive to users.

This issue was identified because the envelope=True path just doesn't
work! We don't have any zmq tests in oslo.messaging, but even in
oslo-incubator the code path isn't tested and has been broken since
I73aad7697cf83ad4aabb3c2058b7cc4f53f783c2

Partial-Bug: #1301132
Change-Id: I6aa2e2ac3cebf443719d64ebcd9eaadc0a9328b8
This commit is contained in:
Mark McLoughlin 2014-04-02 12:59:45 +01:00
parent 6a2c39738c
commit 8aa17091b4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
oslo/messaging/_drivers/impl_zmq.py
View File

@ -909,7 +909,7 @@ class ZmqDriver(base.BaseDriver):
'with oslo.config.cfg.CONF')
def _send(self, target, ctxt, message,
wait_for_reply=None, timeout=None, envelope=True):
wait_for_reply=None, timeout=None, envelope=False):
# FIXME(markmc): remove this temporary hack
class Context(object):