openstack
/
oslo.messaging
Code Issues Proposed changes

Update patch set 16 

Patch Set 16:

(1 comment)

Patch-set: 16
Reviewer: Gerrit User 31039 <31039@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
Gerrit User 31039 2021-10-08 21:09:01 +00:00 committed by Gerrit Code Review
parent 48eb1b0d4c
commit 95e2c46afb
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
3bddd629519af1d10935074ae5d1db294ab3aabf
View File

@ -16,6 +16,24 @@
"revId": "3bddd629519af1d10935074ae5d1db294ab3aabf",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "daf5215f_e3cafe26",
"filename": "oslo_messaging/_drivers/impl_rabbit.py",
"patchSetId": 16
},
"lineNbr": 251,
"author": {
"id": 31039
},
"writtenOn": "2021-10-08T21:09:01Z",
"side": 1,
"message": "if durable:\n args[\u0027x-queue-type\u0027] \u003d \u0027quorum\u0027\nnot every durable queue is quorum\nso this choice is preferred\n args[\u0027x-queue-type\u0027] \u003d \u0027quorum\u0027\n if not durable:\n LOG something or raise exception\nbut since durable will always be true for when rabbit_quorum_queue the exception will never be reached",
"parentUuid": "0c2292b9_266e49f5",
"revId": "3bddd629519af1d10935074ae5d1db294ab3aabf",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}