openstack
/
oslo.messaging
Code Issues Proposed changes

Use assertEqual instead of assertIs for strings 

Checking identity of strings is not a great idea.
It might not work with different implementations. (eg. pypy)
Test usual equality instead.

Change-Id: Ib1a673a0ac116f2c80d066e94a8bd9a9ef8f518a
This commit is contained in:
YAMAMOTO Takashi 2014-06-24 11:07:20 +09:00
parent 4db3cebe23
commit a704a3f1fc
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/notify/test_listener.py
View File

@ -92,7 +92,7 @@ class TestNotifyListener(test_utils.BaseTestCase, ListenerSetupMixin):
self.assertIsInstance(listener.dispatcher,
dispatcher.NotificationDispatcher)
self.assertIs(listener.dispatcher.endpoints, endpoints)
self.assertIs(listener.executor, 'blocking')
self.assertEqual('blocking', listener.executor)
def test_no_target_topic(self):
transport = messaging.get_transport(self.conf, url='fake:')

2
tests/rpc/test_server.py
View File

@ -108,7 +108,7 @@ class TestRPCServer(test_utils.BaseTestCase, ServerSetupMixin):
self.assertIsInstance(server.dispatcher, messaging.RPCDispatcher)
self.assertIs(server.dispatcher.endpoints, endpoints)
self.assertIs(server.dispatcher.serializer, serializer)
self.assertIs(server.executor, 'blocking')
self.assertEqual('blocking', server.executor)
def test_no_target_server(self):
transport = messaging.get_transport(self.conf, url='fake:')