From ad7883f347504f84e991044b1f8d820ad55a7531 Mon Sep 17 00:00:00 2001 From: Gerrit User 28522 <28522@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Mon, 10 May 2021 12:08:48 +0000 Subject: [PATCH] Update patch set 2 Patch Set 2: (1 comment) Patch-set: 2 CC: Gerrit User 28522 <28522@4a232e18-c5a9-48ee-94c0-e04e7cca6543> --- a4abd514e8a810fee5e0e6b43203dd6f4f303d28 | 27 ++++++++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 a4abd514e8a810fee5e0e6b43203dd6f4f303d28 diff --git a/a4abd514e8a810fee5e0e6b43203dd6f4f303d28 b/a4abd514e8a810fee5e0e6b43203dd6f4f303d28 new file mode 100644 index 000000000..928d391d8 --- /dev/null +++ b/a4abd514e8a810fee5e0e6b43203dd6f4f303d28 @@ -0,0 +1,27 @@ +{ + "comments": [ + { + "key": { + "uuid": "7596c65a_69b7c4bd", + "filename": "/COMMIT_MSG", + "patchSetId": 2 + }, + "lineNbr": 7, + "author": { + "id": 28522 + }, + "writtenOn": "2021-05-10T12:08:48Z", + "side": 1, + "message": "Why?\n\nIt could be worth to add some words to justify why we can now remove this module and why we can use the stdlib module instead.\n \nApparently the oslo.utils fnmatch module was originaly implemented to make the fnmatch module thread safe for python 2.7 [1].\n\nWe no longer support py27 since awhile so these changes make sense, however, we need more details in this commit to keep the reason of this removal.\n\nPlease amend your commit message.\n\n[1] https://bugs.python.org/issue23191", + "range": { + "startLine": 7, + "startChar": 0, + "endLine": 7, + "endChar": 29 + }, + "revId": "a4abd514e8a810fee5e0e6b43203dd6f4f303d28", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": true + } + ] +} \ No newline at end of file