openstack/oslo.messaging
Code Issues Proposed changes

Remove old messaging notify driver alias

Browse Source 
15cd99050c6d2714b90059e0faad9f9e3409eaaa added this alias
to workaround an issue with neutron using the internal
path in liberty. That was fixed in neutron in mitaka:

225663888e71d44e9732951f515da925b8799b74

The alias was left for liberty, but liberty is end of life
now so we can remove this.

Change-Id: I145921b98d48e03df38ebcbaebc1a4375911f9ff
This commit is contained in:
Matt Riedemann 2017-03-05 17:32:15 -05:00
parent 8d42484e6f
commit afd4ecfb42
2 changed files with 0 additions and 54 deletions
oslo_messaging
notify
_impl_messaging.py
tests/notify
test_impl_messaging.py

24
oslo_messaging/notify/_impl_messaging.py

@ -1,24 +0,0 @@
# Copyright 2015 IBM Corp.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
from debtcollector import removals
from oslo_messaging.notify.messaging import * # noqa
# NOTE(mriedem): removal depends on how we can cap requirements in
# stable/liberty such that neutron does not try to load this
removals.removed_module(__name__,
oslo_messaging.notify.messaging.__name__,
removal_version='?')

30
oslo_messaging/tests/notify/test_impl_messaging.py

@ -1,30 +0,0 @@
# Copyright 2015 IBM Corp.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
from six.moves import mock
from oslo_messaging.tests import utils as test_utils
class TestDeprecationWarning(test_utils.BaseTestCase):
@mock.patch('warnings.warn')
def test_impl_messaging_deprecation_warning(self, mock_warn):
# Tests that we get a deprecation warning when loading a messaging
# driver out of oslo_messaging.notify._impl_messaging.
from oslo_messaging.notify import _impl_messaging as messaging
driver = messaging.MessagingV2Driver( # noqa
conf={}, topics=['notifications'], transport='rpc')
# Make sure we got a deprecation warning by loading from the alias
self.assertEqual(1, mock_warn.call_count)