openstack
/
oslo.messaging
Code Issues Proposed changes

Update patch set 9 

Patch Set 9:

(2 comments)

Patch-set: 9
Reviewer: Gerrit User 31039 <31039@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
Gerrit User 31039 2021-10-06 20:40:30 +00:00 committed by Gerrit Code Review
parent 478fe4387e
commit b0753a0fae
1 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
d1cb43cf3fcb972dca3e0b19f8f16a4d04302833
View File

@ -34,6 +34,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "bbe6ec5a_9902ddbf",
"filename": "oslo_messaging/_drivers/impl_rabbit.py",
"patchSetId": 8
},
"lineNbr": 245,
"author": {
"id": 31039
},
"writtenOn": "2021-10-06T20:40:30Z",
"side": 1,
"message": "yes which the case for direct queues which should not be replicated and have durable as static false\n consumer \u003d Consumer(\n exchange_name\u003d\u0027\u0027, # using default exchange\n queue_name\u003dtopic,\n routing_key\u003d\u0027\u0027,\n type\u003d\u0027direct\u0027,\n durable\u003dFalse,\n exchange_auto_delete\u003dFalse,\n queue_auto_delete\u003dFalse,\n callback\u003dcallback,\n rabbit_ha_queues\u003dself.rabbit_ha_queues,\n rabbit_queue_ttl\u003dself.rabbit_transient_queues_ttl,\n enable_cancel_on_failover\u003dself.enable_cancel_on_failover,\n rabbit_quorum_queue\u003dself.rabbit_quorum_queue)",
"parentUuid": "33ab6ea6_e00db5f3",
"revId": "d1cb43cf3fcb972dca3e0b19f8f16a4d04302833",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "e930031e_4a2dce3e",
@ -68,6 +86,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "cd537a6b_250f07d6",
"filename": "oslo_messaging/_drivers/impl_rabbit.py",
"patchSetId": 8
},
"lineNbr": 1375,
"author": {
"id": 31039
},
"writtenOn": "2021-10-06T20:40:30Z",
"side": 1,
"message": "quorum_queue are durable by default\nand self.durable is simply (self.amqp_durable_queues or self.rabbit_quorum_queue)",
"parentUuid": "767570c1_3452bce2",
"revId": "d1cb43cf3fcb972dca3e0b19f8f16a4d04302833",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "1fab179e_cf8337d3",