openstack
/
oslo.messaging
Code Issues Proposed changes

Make rpc.dispatcher private 

This is just an implementation detail of the public EventletRPCServer
and BlockingRPCServer classes.

This is important because I'm not sure we've got the right separation
of concerns between executors and dispatchers yet:

  http://lists.openstack.org/pipermail/openstack-dev/2013-June/009934.html

  That implies that you need to pair a tulip-aware executor with a
  tulip-aware dispatcher. We'll probably need to do something similar for
  eventlet too.

I think we need the RPC dispatcher to just know about RPC specific stuff
and there's a single abstraction for I/O framework integration.
This commit is contained in:
Mark McLoughlin 2013-06-07 07:09:49 +01:00
parent 101846c71b
commit b44541e617
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

0
openstack/common/messaging/rpc/dispatcher.py → openstack/common/messaging/rpc/_dispatcher.py
View File

4
openstack/common/messaging/rpc/server.py
View File

@ -15,7 +15,7 @@
from openstack.common.messaging import _server
from openstack.common.messaging._executors import impl_blocking
from openstack.common.messaging.rpc import dispatcher
from openstack.common.messaging.rpc import _dispatcher
class _RPCServer(_server.MessageHandlingServer):
@ -23,7 +23,7 @@ class _RPCServer(_server.MessageHandlingServer):
def __init__(self, transport, target, endpoints, executor_cls):
super(_RPCServer, self).__init__(transport,
target,
dispatcher.RPCDispatcher(endpoints),
_dispatcher.RPCDispatcher(endpoints),
executor_cls)