From b51585968f583b34f382e5b81a5a3939b6dc1a80 Mon Sep 17 00:00:00 2001 From: Javeme Date: Thu, 28 Jan 2016 15:02:53 +0800 Subject: [PATCH] Let PikaDriver inherit base.BaseDriver class oslo_messaging._drivers.impl_pika.PikaDriver inherits object directly, it's better to let PikaDriver inherit BaseDriver for more clear hierarchy. Change-Id: Ia8a6767e89ce069c67c7fee7957d3ea2b3af2092 --- oslo_messaging/_drivers/impl_pika.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/oslo_messaging/_drivers/impl_pika.py b/oslo_messaging/_drivers/impl_pika.py index 796a8247d..dd706ba18 100644 --- a/oslo_messaging/_drivers/impl_pika.py +++ b/oslo_messaging/_drivers/impl_pika.py @@ -16,6 +16,7 @@ import time from oslo_config import cfg from oslo_log import log as logging +from oslo_messaging._drivers import base from oslo_messaging import exceptions import pika_pool import retrying @@ -134,7 +135,7 @@ rpc_opts = [ ] -class PikaDriver(object): +class PikaDriver(base.BaseDriver): def __init__(self, conf, url, default_exchange=None, allowed_remote_exmods=None): opt_group = cfg.OptGroup(name='oslo_messaging_pika', @@ -145,14 +146,14 @@ class PikaDriver(object): conf.register_opts(rpc_opts, group=opt_group) conf.register_opts(notification_opts, group=opt_group) - self.conf = conf - self._pika_engine = pika_drv_engine.PikaEngine( conf, url, default_exchange, allowed_remote_exmods ) self._reply_listener = pika_drv_lstnr.RpcReplyPikaListener( self._pika_engine ) + super(PikaDriver, self).__init__(conf, url, default_exchange, + allowed_remote_exmods) def require_features(self, requeue=False): pass