Browse Source

Renamed PublishErrorsHandler

For greater clarity, that the class is related to logging, PublishErrorsHandler
renamed to LoggingErrorNotificationHandler. Included an alias from the
old name to the new class for backwards-compatibility.

Change-Id: Iae8e26901bab6d5aa7532add31b49a4345b067fe
Closes-Bug: #1287420
changes/89/123389/2
Ilya Pekelny 7 years ago
parent
commit
e15cd36cd5
  1. 2
      doc/source/index.rst
  2. 2
      doc/source/notifier.rst
  3. 3
      oslo/messaging/notify/__init__.py
  4. 5
      oslo/messaging/notify/log_handler.py

2
doc/source/index.rst

@ -215,7 +215,7 @@ contributions to this release.
Changes since 1.3.0a9:
* Expose PublishErrorsHandler in the public API
* Expose LoggingErrorNotificationHandler in the public API
* 1288425_: Add kombu driver library to requirements.txt
* 1255239_: Add unit tests for the qpid driver
* 1261631_: Add unit test for Qpid reconnect order

2
doc/source/notifier.rst

@ -10,5 +10,5 @@ Notifier
.. autoclass:: LoggingNotificationHandler
:members:
.. autoclass:: PublishErrorsHandler
.. autoclass:: LoggingErrorNotificationHandler
:members:

3
oslo/messaging/notify/__init__.py

@ -17,7 +17,8 @@ __all__ = ['Notifier',
'LoggingNotificationHandler',
'get_notification_listener',
'NotificationResult',
'PublishErrorsHandler']
'PublishErrorsHandler',
'LoggingErrorNotificationHandler']
from .notifier import *
from .listener import *

5
oslo/messaging/notify/log_handler.py

@ -15,7 +15,7 @@ import logging
from oslo.config import cfg
class PublishErrorsHandler(logging.Handler):
class LoggingErrorNotificationHandler(logging.Handler):
def __init__(self, *args, **kwargs):
# NOTE(dhellmann): Avoid a cyclical import by doing this one
# at runtime.
@ -36,3 +36,6 @@ class PublishErrorsHandler(logging.Handler):
return
self._notifier.error(None, 'error_notification',
dict(error=record.msg))
PublishErrorsHandler = LoggingErrorNotificationHandler
Loading…
Cancel
Save