openstack
/
oslo.messaging
Code Issues Proposed changes

Renamed PublishErrorsHandler 

For greater clarity, that the class is related to logging, PublishErrorsHandler
renamed to LoggingErrorNotificationHandler. Included an alias from the
old name to the new class for backwards-compatibility.

Change-Id: Iae8e26901bab6d5aa7532add31b49a4345b067fe
Closes-Bug: #1287420
This commit is contained in:
Ilya Pekelny 2014-09-23 10:52:19 +03:00
parent 2b6e24f81b
commit e15cd36cd5
4 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
doc/source/index.rst
View File

@ -215,7 +215,7 @@ contributions to this release.
Changes since 1.3.0a9: Changes since 1.3.0a9:
* Expose PublishErrorsHandler in the public API * Expose LoggingErrorNotificationHandler in the public API
* 1288425_: Add kombu driver library to requirements.txt * 1288425_: Add kombu driver library to requirements.txt
* 1255239_: Add unit tests for the qpid driver * 1255239_: Add unit tests for the qpid driver
* 1261631_: Add unit test for Qpid reconnect order * 1261631_: Add unit test for Qpid reconnect order

2
doc/source/notifier.rst
View File

@ -10,5 +10,5 @@ Notifier
.. autoclass:: LoggingNotificationHandler .. autoclass:: LoggingNotificationHandler
:members: :members:
.. autoclass:: PublishErrorsHandler .. autoclass:: LoggingErrorNotificationHandler
:members: :members:

3
oslo/messaging/notify/__init__.py
View File

@ -17,7 +17,8 @@ __all__ = ['Notifier',
'LoggingNotificationHandler', 'LoggingNotificationHandler',
'get_notification_listener', 'get_notification_listener',
'NotificationResult', 'NotificationResult',
'PublishErrorsHandler'] 'PublishErrorsHandler',
'LoggingErrorNotificationHandler']
from .notifier import * from .notifier import *
from .listener import * from .listener import *

5
oslo/messaging/notify/log_handler.py
View File

@ -15,7 +15,7 @@ import logging
from oslo.config import cfg from oslo.config import cfg
class PublishErrorsHandler(logging.Handler): class LoggingErrorNotificationHandler(logging.Handler):
def __init__(self, *args, **kwargs): def __init__(self, *args, **kwargs):
# NOTE(dhellmann): Avoid a cyclical import by doing this one # NOTE(dhellmann): Avoid a cyclical import by doing this one
# at runtime. # at runtime.
@ -36,3 +36,6 @@ class PublishErrorsHandler(logging.Handler):
return return
self._notifier.error(None, 'error_notification', self._notifier.error(None, 'error_notification',
dict(error=record.msg)) dict(error=record.msg))
PublishErrorsHandler = LoggingErrorNotificationHandler