From 2b89d97888c9b6cd8b4f23e5ae7ce3103d5f9e5b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Herv=C3=A9=20Beraud?= Date: Mon, 18 Jan 2021 14:14:21 +0100 Subject: [PATCH] Deprecate the mandatory flag It will not be possible to deactivate this functionality anymore. Change-Id: I1cbafff03349f7da9224de46285707fbf2a81a68 --- oslo_messaging/_drivers/impl_rabbit.py | 10 +++++++--- .../notes/disable-mandatory-flag-a6210a534f3853f0.yaml | 5 +++++ 2 files changed, 12 insertions(+), 3 deletions(-) create mode 100644 releasenotes/notes/disable-mandatory-flag-a6210a534f3853f0.yaml diff --git a/oslo_messaging/_drivers/impl_rabbit.py b/oslo_messaging/_drivers/impl_rabbit.py index 756641bd9..36a4346b7 100644 --- a/oslo_messaging/_drivers/impl_rabbit.py +++ b/oslo_messaging/_drivers/impl_rabbit.py @@ -171,10 +171,14 @@ rabbit_opts = [ 'we check the heartbeat.'), cfg.BoolOpt('direct_mandatory_flag', default=True, - help='Enable/Disable the RabbitMQ mandatory flag ' - 'for direct send. The direct send is used as reply, ' + deprecated_for_removal=True, + deprecated_reason='Mandatory flag no longer deactivable.', + help='(DEPRECATED) Enable/Disable the RabbitMQ mandatory ' + 'flag for direct send. The direct send is used as reply, ' 'so the MessageUndeliverable exception is raised ' - 'in case the client queue does not exist.'), + 'in case the client queue does not exist.' + 'This flag is deprecated and it will not be possible to ' + 'deactivate this functionality anymore'), cfg.BoolOpt('enable_cancel_on_failover', default=False, help="Enable x-cancel-on-ha-failover flag so that " diff --git a/releasenotes/notes/disable-mandatory-flag-a6210a534f3853f0.yaml b/releasenotes/notes/disable-mandatory-flag-a6210a534f3853f0.yaml new file mode 100644 index 000000000..3c14aad09 --- /dev/null +++ b/releasenotes/notes/disable-mandatory-flag-a6210a534f3853f0.yaml @@ -0,0 +1,5 @@ +--- +upgrade: + - | + Deprecating the ``direct_mandatory_flag``. It will not be possible to + deactivate this functionality anymore.