7b13bc1888
Catch expected exceptions in a way that supports subclasses also being seen as "expected." Log a little more detail about unexpected exceptions in the ExecutorBase so it is easier to add them to the list of expected exceptions. Change-Id: I1bdd628eba717308f0afe1a889efd8711bad6296 Closes-bug: #1276163
68 lines
2.0 KiB
Python
68 lines
2.0 KiB
Python
|
|
# Copyright 2012 OpenStack Foundation
|
|
# Copyright 2013 Red Hat, Inc.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from oslo import messaging
|
|
|
|
from tests import utils as test_utils
|
|
|
|
|
|
class TestExpectedExceptions(test_utils.BaseTestCase):
|
|
|
|
def test_exception(self):
|
|
e = None
|
|
try:
|
|
try:
|
|
raise ValueError()
|
|
except Exception:
|
|
raise messaging.ExpectedException()
|
|
except messaging.ExpectedException as e:
|
|
self.assertIsInstance(e, messaging.ExpectedException)
|
|
self.assertTrue(hasattr(e, 'exc_info'))
|
|
self.assertIsInstance(e.exc_info[1], ValueError)
|
|
|
|
def test_decorator_expected(self):
|
|
class FooException(Exception):
|
|
pass
|
|
|
|
@messaging.expected_exceptions(FooException)
|
|
def naughty():
|
|
raise FooException()
|
|
|
|
self.assertRaises(messaging.ExpectedException, naughty)
|
|
|
|
def test_decorator_expected_subclass(self):
|
|
class FooException(Exception):
|
|
pass
|
|
|
|
class BarException(FooException):
|
|
pass
|
|
|
|
@messaging.expected_exceptions(FooException)
|
|
def naughty():
|
|
raise BarException()
|
|
|
|
self.assertRaises(messaging.ExpectedException, naughty)
|
|
|
|
def test_decorator_unexpected(self):
|
|
class FooException(Exception):
|
|
pass
|
|
|
|
@messaging.expected_exceptions(FooException)
|
|
def really_naughty():
|
|
raise ValueError()
|
|
|
|
self.assertRaises(ValueError, really_naughty)
|