oslo.messaging/d1cb43cf3fcb972dca3e0b19f8f16a4d04302833

{
  "comments": [
    {
      "key": {
        "uuid": "7432add2_c20ea975",
        "filename": "oslo_messaging/_drivers/impl_rabbit.py",
        "patchSetId": 8
      },
      "lineNbr": 151,
      "author": {
        "id": 6618
      },
      "writtenOn": "2021-10-06T20:02:55Z",
      "side": 1,
      "message": "it might be worth adding here, that quorum_queue takes priority over this. (Not this exact wording but something to the effect...)",
      "revId": "d1cb43cf3fcb972dca3e0b19f8f16a4d04302833",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "33ab6ea6_e00db5f3",
        "filename": "oslo_messaging/_drivers/impl_rabbit.py",
        "patchSetId": 8
      },
      "lineNbr": 245,
      "author": {
        "id": 6618
      },
      "writtenOn": "2021-10-06T20:02:55Z",
      "side": 1,
      "message": "it would be nice to add a comment (eg in above docstring) as to what the \u0027durable\u0027 parameter is meant to be used for. I would have thought that just setting rabbit_quorum_queue \u003d true would suffice here.\n\nWhat does it mean if rabbit_quorum_queue is true and durable is false? No quorum.\n\nWhat does it mean if rabbit_quorum_queue is true and rabbit_ha_queues is true and durable is false? no ha and no quorum... Is that the desired behaviour?",
      "revId": "d1cb43cf3fcb972dca3e0b19f8f16a4d04302833",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "bbe6ec5a_9902ddbf",
        "filename": "oslo_messaging/_drivers/impl_rabbit.py",
        "patchSetId": 8
      },
      "lineNbr": 245,
      "author": {
        "id": 31039
      },
      "writtenOn": "2021-10-06T20:40:30Z",
      "side": 1,
      "message": "yes which the case for direct queues which should not be replicated and have durable as static false\n       consumer \u003d Consumer(\n            exchange_name\u003d\u0027\u0027,  # using default exchange\n            queue_name\u003dtopic,\n            routing_key\u003d\u0027\u0027,\n            type\u003d\u0027direct\u0027,\n            durable\u003dFalse,\n            exchange_auto_delete\u003dFalse,\n            queue_auto_delete\u003dFalse,\n            callback\u003dcallback,\n            rabbit_ha_queues\u003dself.rabbit_ha_queues,\n            rabbit_queue_ttl\u003dself.rabbit_transient_queues_ttl,\n            enable_cancel_on_failover\u003dself.enable_cancel_on_failover,\n            rabbit_quorum_queue\u003dself.rabbit_quorum_queue)",
      "parentUuid": "33ab6ea6_e00db5f3",
      "revId": "d1cb43cf3fcb972dca3e0b19f8f16a4d04302833",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "e930031e_4a2dce3e",
        "filename": "oslo_messaging/_drivers/impl_rabbit.py",
        "patchSetId": 8
      },
      "lineNbr": 276,
      "author": {
        "id": 6618
      },
      "writtenOn": "2021-10-06T20:02:55Z",
      "side": 1,
      "message": "wondering if this is a good idea. Sometimes, people write code like Consumer(\u0027xchangename\u0027, \u0027queuename\u0027, route-key, some-type, true, true, false, some-callback, false, None, 0, False).\nSo adding rabbit_quorum_queue in the middle will cause things to fail. I suggest adding it to the end of the list of parameters.",
      "revId": "d1cb43cf3fcb972dca3e0b19f8f16a4d04302833",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "767570c1_3452bce2",
        "filename": "oslo_messaging/_drivers/impl_rabbit.py",
        "patchSetId": 8
      },
      "lineNbr": 1375,
      "author": {
        "id": 6618
      },
      "writtenOn": "2021-10-06T20:02:55Z",
      "side": 1,
      "message": "I\u0027m not familiar with this code so this might be a dumb question. Why is amqp_durable_queues not use any more? Looks like amqp_durable_queues is set via a config, so if it isn\u0027t used, should the config be deleted or deprecated or something (and mentioned in the release notes)?",
      "revId": "d1cb43cf3fcb972dca3e0b19f8f16a4d04302833",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "cd537a6b_250f07d6",
        "filename": "oslo_messaging/_drivers/impl_rabbit.py",
        "patchSetId": 8
      },
      "lineNbr": 1375,
      "author": {
        "id": 31039
      },
      "writtenOn": "2021-10-06T20:40:30Z",
      "side": 1,
      "message": "quorum_queue are durable by default\nand self.durable is simply (self.amqp_durable_queues or self.rabbit_quorum_queue)",
      "parentUuid": "767570c1_3452bce2",
      "revId": "d1cb43cf3fcb972dca3e0b19f8f16a4d04302833",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    },
    {
      "key": {
        "uuid": "1fab179e_cf8337d3",
        "filename": "releasenotes/notes/adding_support_for_quorum_queues-3101d055b492289e.yaml",
        "patchSetId": 8
      },
      "lineNbr": 5,
      "author": {
        "id": 6618
      },
      "writtenOn": "2021-10-06T20:02:55Z",
      "side": 1,
      "message": "nit s/is sets/is set/",
      "revId": "d1cb43cf3fcb972dca3e0b19f8f16a4d04302833",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": true
    }
  ]
}