openstack/oslo.middleware
Code Issues Proposed changes

Remove usage of parameter enforce_type

Browse Source 
We deprecate and change parameter enforce_type's default value to
True[1], and will remove it int the future, so don't need it anymore.

[1] https://review.openstack.org/328692

Change-Id: I243444f53e14543c5e4ae4c40d9582fb2d17e155
This commit is contained in:
ChangBo Guo(gcb) 2017-05-31 14:50:20 +08:00
parent ac68f40bd3
commit 6a28ca245c
4 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
oslo_middleware/base.py
View File

@ -99,8 +99,7 @@ class ConfigurableMiddleware(object):
def _conf_get(self, key, group="oslo_middleware"):
if key in self.conf:
# Validate value type
self.oslo_conf.set_override(key, self.conf[key], group=group,
enforce_type=True)
self.oslo_conf.set_override(key, self.conf[key], group=group)
return getattr(getattr(self.oslo_conf, group), key)
@staticmethod

3
oslo_middleware/healthcheck/pluginbase.py
View File

@ -44,6 +44,5 @@ class HealthcheckBaseExtension(object):
def _conf_get(self, key, group='healthcheck'):
if key in self.conf:
# Validate value type
self.oslo_conf.set_override(key, self.conf[key], group=group,
enforce_type=True)
self.oslo_conf.set_override(key, self.conf[key], group=group)
return getattr(getattr(self.oslo_conf, group), key)

6
oslo_middleware/tests/test_http_proxy_to_wsgi.py
View File

@ -31,8 +31,7 @@ class TestHTTPProxyToWSGI(test_base.BaseTestCase):
self.middleware = http_proxy_to_wsgi.HTTPProxyToWSGI(fake_app)
self.middleware.oslo_conf.set_override('enable_proxy_headers_parsing',
True,
group='oslo_middleware',
enforce_type=True)
group='oslo_middleware')
self.request = webob.Request.blank('/foo/bar', method='POST')
def test_backward_compat(self):
@ -139,8 +138,7 @@ class TestHTTPProxyToWSGIDisabled(test_base.BaseTestCase):
self.middleware = http_proxy_to_wsgi.HTTPProxyToWSGI(fake_app)
self.middleware.oslo_conf.set_override('enable_proxy_headers_parsing',
False,
group='oslo_middleware',
enforce_type=True)
group='oslo_middleware')
self.request = webob.Request.blank('/foo/bar', method='POST')
def test_no_headers(self):

2
oslo_middleware/tests/test_ssl.py
View File

@ -31,7 +31,7 @@ class SSLMiddlewareTest(base.BaseTestCase):
if secure_proxy_ssl_header:
middleware.oslo_conf.set_override(
'secure_proxy_ssl_header', secure_proxy_ssl_header,
group='oslo_middleware', enforce_type=True)
group='oslo_middleware')
request = webob.Request.blank('http://example.com/', headers=headers)
# Ensure ssl middleware does not stop pipeline execution