openstack/oslo.middleware
Code Issues Proposed changes

remove bad entry point test logic

Browse Source 
The test being removed verifies that stevedore and pkg_resources work as
expected, and enforce an import scheme through the getattr calls that
should be left up to the plugin definition and not hard-coded into the
tests.

Change-Id: I7ccc0a624e3822de1ea6864f49a254c80a35ae53
This commit is contained in:
Doug Hellmann 2015-11-16 21:13:03 +00:00
parent 88ad62563d
commit 7abf1bfa3e
1 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
oslo_middleware/tests/test_entry_points.py
View File

@ -14,8 +14,6 @@ from oslotest import base
import stevedore
from testtools import matchers
import oslo_middleware
class TestPasteDeploymentEntryPoints(base.BaseTestCase):
@ -38,10 +36,3 @@ class TestPasteDeploymentEntryPoints(base.BaseTestCase):
factory_names = [extension.name for extension in em]
self.assertThat(factory_names,
matchers.ContainsAll(factory_classes))
# Ensure that we can create instances of the filter factories
for factory_name, class_name in factory_classes.items():
e = [m for m in em if m.name == factory_name][0]
factory = getattr(oslo_middleware, factory_name)
factory_class = getattr(factory, class_name).factory
self.assertEqual(factory_class, e.plugin)