openstack
/
oslo.policy
Code Issues Proposed changes

Fix generation of sample policy files 

Generation of sample policy files was broken when exclude_deprecated was
added as an extra argument to the generate_sample function in
I6d02eb4d8f94323a806fab991ba2f1c3bbf71d04. It was passed as the fourth
argument, which is actually include_help. Because it defaults to False,
this turned sample policy files into actual policy files.

Fix by using keyword arguments instead.

Change-Id: I5478b1c8e7fd2f1b01f63602998194bab3683f7c
Closes-Bug: #1975682
This commit is contained in:
Pierre Riteau 2022-05-25 11:04:33 +02:00
parent 6471443811
commit 5bd767be79
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
oslo_policy/generator.py
View File

@ -545,8 +545,9 @@ def generate_sample(args=None, conf=None):
conf.register_opts(GENERATOR_OPTS + RULE_OPTS)
conf(args)
_check_for_namespace_opt(conf)
_generate_sample(conf.namespace, conf.output_file, conf.format,
conf.exclude_deprecated)
_generate_sample(conf.namespace, output_file=conf.output_file,
output_format=conf.format,
exclude_deprecated=conf.exclude_deprecated)
def generate_policy(args=None):