openstack/oslo.rootwrap
Code Issues Proposed changes

Update patch set 7

Browse Source 
Patch Set 7: Backport-Candidate+1

(5 comments)

Patch-set: 7
Reviewer: Gerrit User 27419 <27419@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Backport-Candidate=+1
Attention: {"person_ident":"Gerrit User 27419 \u003c27419@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"David Vallee Delisle replied on the change"}
Attention: {"person_ident":"Gerrit User 308 \u003c308@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"David Vallee Delisle replied on the change"}
This commit is contained in:
Gerrit User 27419 2022-01-13 13:45:36 +00:00 committed by Gerrit Code Review
parent 63eff62568
commit 8566a6ace9
2 changed files with 111 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

90
0e9b3b4fb79c612b191cdbb70ffe78c1d0869c2c
View File

@ -40,6 +40,30 @@
"revId": "0e9b3b4fb79c612b191cdbb70ffe78c1d0869c2c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "6eaa9a88_0b542f47",
"filename": "oslo_rootwrap/filters.py",
"patchSetId": 6
},
"lineNbr": 78,
"author": {
"id": 27419
},
"writtenOn": "2022-01-13T13:45:36Z",
"side": 1,
"message": "Done",
"parentUuid": "1fc2ab1a_944b1368",
"range": {
"startLine": 78,
"startChar": 12,
"endLine": 78,
"endChar": 21
},
"revId": "0e9b3b4fb79c612b191cdbb70ffe78c1d0869c2c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -63,6 +87,30 @@
"revId": "0e9b3b4fb79c612b191cdbb70ffe78c1d0869c2c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "8df02bf8_56987a21",
"filename": "oslo_rootwrap/filters.py",
"patchSetId": 6
},
"lineNbr": 79,
"author": {
"id": 27419
},
"writtenOn": "2022-01-13T13:45:36Z",
"side": 1,
"message": "Done",
"parentUuid": "d8ab235c_b8ce3480",
"range": {
"startLine": 79,
"startChar": 12,
"endLine": 79,
"endChar": 21
},
"revId": "0e9b3b4fb79c612b191cdbb70ffe78c1d0869c2c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -86,6 +134,30 @@
"revId": "0e9b3b4fb79c612b191cdbb70ffe78c1d0869c2c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "dade89fc_a6f6bd5c",
"filename": "oslo_rootwrap/filters.py",
"patchSetId": 6
},
"lineNbr": 80,
"author": {
"id": 27419
},
"writtenOn": "2022-01-13T13:45:36Z",
"side": 1,
"message": "Done",
"parentUuid": "1c7452b6_aa560c04",
"range": {
"startLine": 80,
"startChar": 19,
"endLine": 80,
"endChar": 41
},
"revId": "0e9b3b4fb79c612b191cdbb70ffe78c1d0869c2c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -102,6 +174,24 @@
"message": "I would also explicitly return False if no userargs are present, like the original function (to minimize the proposed change)",
"revId": "0e9b3b4fb79c612b191cdbb70ffe78c1d0869c2c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "9f3ac433_7f97b7e7",
"filename": "oslo_rootwrap/filters.py",
"patchSetId": 6
},
"lineNbr": 81,
"author": {
"id": 27419
},
"writtenOn": "2022-01-13T13:45:36Z",
"side": 1,
"message": "Done",
"parentUuid": "00ed1882_c984fc59",
"revId": "0e9b3b4fb79c612b191cdbb70ffe78c1d0869c2c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

21
1b1b960d0d6b0ddf63c5b0f9c6aa7c10a1914073 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "d980d23a_11aeb061",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 7
},
"lineNbr": 0,
"author": {
"id": 27419
},
"writtenOn": "2022-01-13T13:45:36Z",
"side": 1,
"message": "Thanks for the feedback.",
"revId": "1b1b960d0d6b0ddf63c5b0f9c6aa7c10a1914073",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}