From 5587e9555ed41dbbe48c98652d50313cacb31145 Mon Sep 17 00:00:00 2001 From: Stephen Finucane Date: Fri, 22 Dec 2023 17:53:54 +0000 Subject: [PATCH] pre-commit: Bump versions hacking now has a native hook. Change-Id: Ibdf50f4e1e1cfe6056f25322f66d4e95f5930dc0 Signed-off-by: Stephen Finucane --- .pre-commit-config.yaml | 23 +++++------------------ oslo_serialization/jsonutils.py | 2 +- 2 files changed, 6 insertions(+), 19 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 08aef91..ca3acbe 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -1,15 +1,6 @@ -# We from the Oslo project decided to pin repos based on the -# commit hash instead of the version tag to prevend arbitrary -# code from running in developer's machines. To update to a -# newer version, run `pre-commit autoupdate` and then replace -# the newer versions with their commit hash. - -default_language_version: - python: python3 - repos: - repo: https://github.com/pre-commit/pre-commit-hooks - rev: 9136088a246768144165fcc3ecc3d31bb686920a # v3.3.0 + rev: v4.5.0 hooks: - id: trailing-whitespace # Replaces or checks mixed line ending @@ -27,13 +18,9 @@ repos: - id: debug-statements - id: check-yaml files: .*\.(yaml|yml)$ - - repo: local + - repo: https://opendev.org/openstack/hacking + rev: 6.1.0 hooks: - - id: flake8 - name: flake8 - additional_dependencies: - - hacking>=3.0.1,<3.1.0 - language: python - entry: flake8 - files: '^.*\.py$' + - id: hacking + additional_dependencies: [] exclude: '^(doc|releasenotes|tools)/.*$' diff --git a/oslo_serialization/jsonutils.py b/oslo_serialization/jsonutils.py index a2a700b..adc4557 100644 --- a/oslo_serialization/jsonutils.py +++ b/oslo_serialization/jsonutils.py @@ -135,7 +135,7 @@ def to_primitive(value, convert_instances=False, convert_datetime=True, # value of itertools.count doesn't get caught by nasty_type_tests # and results in infinite loop when list(value) is called. - if type(value) == itertools.count: + if type(value) is itertools.count: return fallback(value) if any(test(value) for test in _nasty_type_tests):