From 501b9e85f035cd71a006722eb905c8ad3a3aacef Mon Sep 17 00:00:00 2001 From: Takashi Kajinami Date: Tue, 8 Jul 2025 00:26:59 +0900 Subject: [PATCH] Revert "Fix keyword-arg-before-vararg warning" This reverts commit 0e4531adc7a1d5c631a83384b32f0418f225c788. Reason for revert: This breaks existing usage with f passed as an argument (not as a keyword argument). Closes-Bug: #2116102 Change-Id: Iac6ced988f824d8a8251baee62d0e22d600790f4 Signed-off-by: Takashi Kajinami --- oslo_service/backend/threading/loopingcall.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/oslo_service/backend/threading/loopingcall.py b/oslo_service/backend/threading/loopingcall.py index df8b3d9a..7abad429 100644 --- a/oslo_service/backend/threading/loopingcall.py +++ b/oslo_service/backend/threading/loopingcall.py @@ -98,7 +98,7 @@ class LoopingCallBase: _RUN_ONLY_ONE_MESSAGE = _( "A looping call can only run one function at a time") - def __init__(self, *args, f=None, **kwargs): + def __init__(self, f=None, *args, **kwargs): self.args = args self.kwargs = kwargs self.f = f @@ -293,7 +293,7 @@ class BackOffLoopingCall(LoopingCallBase): "A dynamic backoff interval looping call can only run one function at" " a time") - def __init__(self, *args, f=None, **kwargs): + def __init__(self, f=None, *args, **kwargs): super().__init__(f=f, *args, **kwargs) self._error_time = 0 self._interval = 1