openstack/oslo.service
Code Issues Proposed changes

Revert "Fix keyword-arg-before-vararg warning"

Browse Source 
This reverts commit 0e4531adc7.

Reason for revert:
This breaks existing usage with f passed as an argument (not as
a keyword argument).

Closes-Bug: #2116102
Change-Id: Iac6ced988f824d8a8251baee62d0e22d600790f4
Signed-off-by: Takashi Kajinami <kajinamit@oss.nttdata.com>
This commit is contained in:
Takashi Kajinami
2025-07-08 00:26:59 +09:00
parent 9c0e66c9b3
commit 501b9e85f0
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
oslo_service/backend/threading/loopingcall.py
View File

@@ -98,7 +98,7 @@ class LoopingCallBase:
_RUN_ONLY_ONE_MESSAGE = _( _RUN_ONLY_ONE_MESSAGE = _(
"A looping call can only run one function at a time") "A looping call can only run one function at a time")
def __init__(self, *args, f=None, **kwargs): def __init__(self, f=None, *args, **kwargs):
self.args = args self.args = args
self.kwargs = kwargs self.kwargs = kwargs
self.f = f self.f = f
@@ -293,7 +293,7 @@ class BackOffLoopingCall(LoopingCallBase):
"A dynamic backoff interval looping call can only run one function at" "A dynamic backoff interval looping call can only run one function at"
" a time") " a time")
def __init__(self, *args, f=None, **kwargs): def __init__(self, f=None, *args, **kwargs):
super().__init__(f=f, *args, **kwargs) super().__init__(f=f, *args, **kwargs)
self._error_time = 0 self._error_time = 0
self._interval = 1 self._interval = 1