openstack/oslo.service
Code Issues Proposed changes

Enforce H405 check

Browse Source 
Change-Id: I61170d3b8cebd6e3e381f33ddc52b6d0174efec4
This commit is contained in:
Elena Ezhova
2015-06-24 16:23:12 +03:00
parent f544d9b3f9
commit eea13af645
4 changed files with 12 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
oslo_service/periodic_task.py
View File

@@ -149,8 +149,9 @@ class _PeriodicTasksMeta(type):
def _nearest_boundary(last_run, spacing): def _nearest_boundary(last_run, spacing):
"""Find nearest boundary which is in the past, which is a multiple of the """Find the nearest boundary in the past.
spacing with the last run as an offset.
The boundary is a multiple of the spacing with the last run as an offset.
Eg if last run was 10 and spacing was 7, the new last run could be: 17, 24, Eg if last run was 10 and spacing was 7, the new last run could be: 17, 24,
31, 38... 31, 38...

3
oslo_service/tests/test_periodic.py
View File

@@ -197,8 +197,7 @@ class PeriodicTasksTestCase(base.ServiceBaseTestCase):
class ManagerMetaTestCase(base.ServiceBaseTestCase): class ManagerMetaTestCase(base.ServiceBaseTestCase):
"""Tests for the meta class which manages the creation of periodic tasks. """Tests for the meta class which manages creation of periodic tasks."""
"""
def test_meta(self): def test_meta(self):
class Manager(periodic_task.PeriodicTasks): class Manager(periodic_task.PeriodicTasks):

11
oslo_service/threadgroup.py
View File

@@ -25,7 +25,8 @@ LOG = logging.getLogger(__name__)
def _thread_done(gt, *args, **kwargs): def _thread_done(gt, *args, **kwargs):
"""Callback function to be passed to GreenThread.link() when we spawn() """Callback function to be passed to GreenThread.link() when we spawn().
Calls the :class:`ThreadGroup` to notify if. Calls the :class:`ThreadGroup` to notify if.
""" """
@@ -33,9 +34,11 @@ def _thread_done(gt, *args, **kwargs):
class Thread(object): class Thread(object):
"""Wrapper around a greenthread, that holds a reference to the """Wrapper around a greenthread.
:class:`ThreadGroup`. The Thread will notify the :class:`ThreadGroup` when
it has done so it can be removed from the threads list. Holds a reference to the :class:`ThreadGroup`. The Thread will notify
the :class:`ThreadGroup` when it has done so it can be removed from
the threads list.
""" """
def __init__(self, thread, group): def __init__(self, thread, group):
self.thread = thread self.thread = thread

2
tox.ini
View File

@@ -32,7 +32,7 @@ commands = python setup.py testr --coverage --testr-args='{posargs}'
# E123, E125 skipped as they are invalid PEP-8. # E123, E125 skipped as they are invalid PEP-8.
show-source = True show-source = True
ignore = E123,E125,H405 ignore = E123,E125
builtins = _ builtins = _
exclude=.venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build exclude=.venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build