openstack/oslo.utils
Code Issues Proposed changes

Change assertTrue(isinstance()) by optimal assert

Browse Source 
Some of tests use different method of
assertTrue(isinstance(A, B)) or assertEqual(type(A), B).
The correct way is to use assertIsInstance(A, B) provided by testtools

Change-Id: I8f721e98928c72847b720a64dc7020eb0ffe94fe
This commit is contained in:
melissaml 2016-10-11 13:12:54 +08:00
parent d1dc35196e
commit 31ed2a2be7
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
oslo_utils/tests/test_importutils.py
View File

@ -109,11 +109,11 @@ class ImportUtilsTest(test_base.BaseTestCase):
def test_import_object(self):
dt = importutils.import_object('datetime.time')
self.assertTrue(isinstance(dt, sys.modules['datetime'].time))
self.assertIsInstance(dt, sys.modules['datetime'].time)
def test_import_object_with_args(self):
dt = importutils.import_object('datetime.datetime', 2012, 4, 5)
self.assertTrue(isinstance(dt, sys.modules['datetime'].datetime))
self.assertIsInstance(dt, sys.modules['datetime'].datetime)
self.assertEqual(dt, datetime.datetime(2012, 4, 5))
def test_try_import(self):