openstack/oslo.utils
Code Issues Proposed changes

Make return type from urlsplit private

Browse Source 
The ModifiedSplitResult class should be private because when we drop
python 2.6 support we can replace the urlsplit() wrapper we have with a
reference to the one in the python standard library, which returns a
different type.

Change-Id: I413de125c58ee54a0aaaf608f57283e76283bf84
This commit is contained in:
Doug Hellmann
2014-07-23 16:21:53 -04:00
parent 51e6c14a75
commit b11cc9a572
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
oslo/utils/netutils.py
View File

@@ -75,7 +75,7 @@ def parse_host_port(address, default_port=None):
return (host, None if port is None else int(port)) return (host, None if port is None else int(port))
class ModifiedSplitResult(parse.SplitResult): class _ModifiedSplitResult(parse.SplitResult):
"""Split results class for urlsplit.""" """Split results class for urlsplit."""
# NOTE(dims): The functions below are needed for Python 2.6.x. # NOTE(dims): The functions below are needed for Python 2.6.x.
@@ -105,8 +105,8 @@ def urlsplit(url, scheme='', allow_fragments=True):
path, fragment = path.split('#', 1) path, fragment = path.split('#', 1)
if '?' in path: if '?' in path:
path, query = path.split('?', 1) path, query = path.split('?', 1)
return ModifiedSplitResult(scheme, netloc, return _ModifiedSplitResult(scheme, netloc,
path, query, fragment) path, query, fragment)
def set_tcp_keepalive(sock, tcp_keepalive=True, def set_tcp_keepalive(sock, tcp_keepalive=True,