openstack
/
oslo.utils
Code Issues Proposed changes

Revert "Use assertTrue/False instead of assertEqual(T/F)" 

assertTrue is weaker than assertEqual(True,..) because
assertEqual also compares the type.

If we expect a boolean and know that we are getting a boolean then
assert for a boolean, not for something that evaluates to true.

This reverts commit e995d73488.

Change-Id: Ia3c5418b8d98ad23b70c2c0191a64a4f2f590040
This commit is contained in:
Jordan Pittier 2016-01-28 17:02:43 +00:00
parent e995d73488
commit cdec8545b8
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
oslo_utils/tests/test_reflection.py
View File

@ -290,10 +290,10 @@ class GetCallableArgsTest(test_base.BaseTestCase):
class AcceptsKwargsTest(test_base.BaseTestCase):
def test_no_kwargs(self):
self.assertFalse(reflection.accepts_kwargs(mere_function))
self.assertEqual(False, reflection.accepts_kwargs(mere_function))
def test_with_kwargs(self):
self.assertTrue(reflection.accepts_kwargs(function_with_kwargs))
self.assertEqual(True, reflection.accepts_kwargs(function_with_kwargs))
class GetClassNameTest(test_base.BaseTestCase):