openstack/oslo.versionedobjects
Code Issues Proposed changes

Replace deprecated inspect.getargspec

Browse Source 
inspect.getargspec was deprecated since Python 3.0 and
inspect.getfullargspec is its replacement with correct handling of
function annotations and keyword-only parameters[1].

[1] https://docs.python.org/3/library/inspect.html#inspect.getargspec

Change-Id: I29478df88665ee5311e3ba308ab645c47e5b0fc8
This commit is contained in:
Takashi Kajinami 2021-07-15 20:50:05 +09:00
parent 63cdc14853
commit 07fd2f2c47
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
oslo_versionedobjects/test.py
View File

@ -178,8 +178,8 @@ class TestCase(testtools.TestCase):
baseclass) baseclass)
for name in sorted(implmethods.keys()): for name in sorted(implmethods.keys()):
baseargs = inspect.getargspec(basemethods[name]) baseargs = inspect.getfullargspec(basemethods[name])
implargs = inspect.getargspec(implmethods[name]) implargs = inspect.getfullargspec(implmethods[name])
self.assertEqual(baseargs, implargs, self.assertEqual(baseargs, implargs,
"%s args don't match base class %s" % "%s args don't match base class %s" %

6
oslo_versionedobjects/tests/test_fixture.py
View File

@ -757,9 +757,11 @@ class TestMethodSpec(test.TestCase):
self._test_method3 = test_method3 self._test_method3 = test_method3
def test_method_spec_compat(self): def test_method_spec_compat(self):
self.assertEqual(inspect.getargspec(self._test_method1), self.assertEqual(inspect.ArgSpec(args=['a', 'b', 'kw1'], varargs=None,
keywords='kwargs', defaults=(123,)),
fixture.get_method_spec(self._test_method1)) fixture.get_method_spec(self._test_method1))
self.assertEqual(inspect.getargspec(self._test_method2), self.assertEqual(inspect.ArgSpec(args=['a', 'b'], varargs='args',
keywords=None, defaults=None),
fixture.get_method_spec(self._test_method2)) fixture.get_method_spec(self._test_method2))
self.assertEqual(inspect.getfullargspec(self._test_method3), self.assertEqual(inspect.getfullargspec(self._test_method3),
fixture.get_method_spec(self._test_method3)) fixture.get_method_spec(self._test_method3))