openstack/oslo.versionedobjects
Code Issues Proposed changes

Bump bandit and make oslo.versionedobjects compatible with latest rules

Browse Source 
Change-Id: I3da9745c8f9f4b5832f41933af6f177b0f876bb5
This commit is contained in:
Hervé Beraud 2023-05-19 16:22:58 +02:00 committed by Takashi Kajinami
parent 120e23d84f
commit f78601fd8e
2 changed files with 19 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
oslo_versionedobjects/tests/test_fixture.py
View File

@ -538,8 +538,13 @@ class TestObjectVersionChecker(test.TestCase):
exp_methods = sorted([('remotable_method', argspec),
('remotable_classmethod', argspec)])
expected_relevant_data = (exp_fields, exp_methods)
# NOTE(hberaud) the following hashlib usage will emit a bandit
# warning. It can be solved by passing `usedforsecurity=False` to
# the md5 function, however, this parameter was introduced with py39
# so passing it will break py38 unittest. I'd suggest to ignore this
# bandit rule while py38 is in our supported runtimes.
expected_hash = hashlib.md5(bytes(repr(
expected_relevant_data).encode())).hexdigest()
expected_relevant_data).encode())).hexdigest() # nosec
expected_fp = '%s-%s' % (MyObject.VERSION, expected_hash)
self.assertEqual(expected_fp, fp, "_get_fingerprint() did not "
@ -564,8 +569,13 @@ class TestObjectVersionChecker(test.TestCase):
child_versions.items()))
exp_relevant_data = (exp_fields, exp_methods, exp_child_versions)
# NOTE(hberaud) the following hashlib usage will emit a bandit
# warning. It can be solved by passing `usedforsecurity=False` to
# the md5 function, however, this parameter was introduced with py39
# so passing it will break py38 unittest. I'd suggest to ignore this
# bandit rule while py38 is in our supported runtimes.
expected_hash = hashlib.md5(bytes(repr(
exp_relevant_data).encode())).hexdigest()
exp_relevant_data).encode())).hexdigest() # nosec
expected_fp = '%s-%s' % (MyObject.VERSION, expected_hash)
self.assertEqual(expected_fp, fp, "_get_fingerprint() did not "
@ -594,8 +604,13 @@ class TestObjectVersionChecker(test.TestCase):
exp_extra_data = ExtraDataObj
exp_relevant_data = (exp_fields, exp_methods, exp_extra_data)
# NOTE(hberaud) the following hashlib usage will emit a bandit
# warning. It can be solved by passing `usedforsecurity=False` to
# the md5 function, however, this parameter was introduced with py39
# so passing it will break py38 unittest. I'd suggest to ignore this
# bandit rule while py38 is in our supported runtimes.
expected_hash = hashlib.md5(bytes(repr(
exp_relevant_data).encode())).hexdigest()
exp_relevant_data).encode())).hexdigest() # nosec
expected_fp = '%s-%s' % (ExtraDataObj.VERSION, expected_hash)
self.assertEqual(expected_fp, fp, "_get_fingerprint() did not "

2
test-requirements.txt
View File

@ -11,6 +11,6 @@ stestr>=2.0.0 # Apache-2.0
fixtures>=3.0.0 # Apache-2.0/BSD
# Bandit security code scanner
bandit>=1.6.0,<1.7.0 # Apache-2.0
bandit>=1.7.0,<1.8.0 # Apache-2.0
pre-commit>=2.6.0 # MIT