openstack
/
oslosphinx
Code Issues Proposed changes

Update patch set 5 

Patch Set 5: Looks good to me (core reviewer); Approved

(2 inline comments)

Looks great to me. Only whitespace changes since dims' +2. Let's get this in.

Patch-set: 5
Reviewer: Gerrit User 1247 <1247@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2
Label: Workflow=+1
This commit is contained in:
Gerrit User 1247 2013-07-03 19:18:36 +00:00 committed by Gerrit Code Review
parent 00268373bd
commit 6c59663d67
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
ac91ff16bc7e0ec7bd9157cef04aae5f5518663a Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"key": {
"uuid": "AAAAPn//Vhk\u003d",
"filename": "setup.cfg",
"patchSetId": 5
},
"lineNbr": 19,
"author": {
"id": 1247
},
"writtenOn": "2013-07-03T19:18:36Z",
"side": 1,
"message": "A stray tab here",
"revId": "ac91ff16bc7e0ec7bd9157cef04aae5f5518663a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAPn//Vhg\u003d",
"filename": "setup.cfg",
"patchSetId": 5
},
"lineNbr": 30,
"author": {
"id": 1247
},
"writtenOn": "2013-07-03T19:18:36Z",
"side": 1,
"message": "Extra newline",
"revId": "ac91ff16bc7e0ec7bd9157cef04aae5f5518663a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}